return MOI.TIME_LIMIT when the solver times out

[zengjian-hu-rai]

Should we return MOI.TIME_LIMIT instead of OTHER_ERROR when the solver hits the preset time_limit?

Understand it's tricky to know whether the solver truly times out. Looks like the solver (chuffed) returns UNKNOWN when it hits the time limit.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (085d2ad) 97.37% compared to head (54934c9) 97.16%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   97.37%   97.16%   -0.21%     
==========================================
  Files           3        3              
  Lines         457      459       +2     
==========================================
+ Hits          445      446       +1     
- Misses         12       13       +1     

Files	Coverage Δ
src/optimize.jl	92.30% <100.00%> (-0.61%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[odow]

As a hack, this is okay. Does mini zinc not have better status reporting options?

[odow]

Looks like there isn't

--unsat-msg (--unsatisfiable-msg), --unbounded-msg, --unsatorunbnd-msg,
        --unknown-msg, --error-msg, --search-complete-msg <msg>
    Specify solution status messages. The defaults:
    "=====UNSATISFIABLE=====", "=====UNSATorUNBOUNDED=====", "=====UNBOUNDED=====",
    "=====UNKNOWN=====", "=====ERROR=====", "==========", respectively.

[chriscoey]

AFAICT these are the minizinc statuses https://minizinc-python.readthedocs.io/en/latest/api.html#minizinc.result.Status and it does not really have the level of granularity on termination statuses that MOI does

[odow]

Happy with this? Any changes?

[zengjian-hu-rai]

Happy with this? Any changes?

yes!