-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement solve_all for MiniZinc #43
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 97.32% 97.37% +0.05%
==========================================
Files 3 3
Lines 448 457 +9
==========================================
+ Hits 436 445 +9
Misses 12 12
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few change suggestions, but all stemming from the high-level comment:
- Let's just have one
num_solutions
option, store it in theoptions
dictionary, and always add it to the command line args.
Thanks for the great suggestions! Hopefully I've addressed them all. |
Co-authored-by: Oscar Dowson <[email protected]>
Co-authored-by: Oscar Dowson <[email protected]>
Co-authored-by: Oscar Dowson <[email protected]>
Co-authored-by: Oscar Dowson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I added a bunch more changes. But this looks good now. Let me know if you're still happy and I'll merge.
Yes it looks great! thanks so much for polishing! |
No problem. Sorry for being somewhat pedantic, but I hope you'll agree it looks a lot tidier now. |
Yes it does, thanks again. |
Add option num_solutions
num_solutions will be default to 1, unless it's set explicitly
Changed primal_solution to primal_solutions to hold 1+ solutions
Modified MOI.ResultCount, MOI.TerminationStatus.
If num_solutions > 1 and we've found the given number of solutions, return MOI.SOLUTION_LIMIT, otherwise MOI.OPTIMAL