Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] build on Julia v1.9 to support Pkg extensions #3398

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Jun 2, 2023

A necessary precursor for #3383. Haven't run locally, so let's see if any changes need to be made.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c6ce4c5) 98.05% compared to head (77bde2f) 98.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3398   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files          34       34           
  Lines        4926     4926           
=======================================
  Hits         4830     4830           
  Misses         96       96           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow
Copy link
Member Author

odow commented Jun 2, 2023

Blocked by the need to first update the MOI docs to Julia 1.9...

@odow
Copy link
Member Author

odow commented Jun 7, 2023

@jd-foster the SDP example is pretty flakey. Any suggestions for how to make it more robust?

@jd-foster
Copy link
Collaborator

Yeah, it keeps killing the CI. I see you increased the tolerances, that's one option. Maybe we need try SCS again (usually these types of problems get solved with Mosek)?

@odow odow merged commit 8475ce6 into master Jun 7, 2023
@odow odow deleted the od/build-docs branch June 7, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants