Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Gurobi v11 #531

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Support for Gurobi v11 #531

merged 5 commits into from
Nov 2, 2023

Conversation

simonbowly
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 478 lines in your changes are missing coverage. Please review.

Comparison is base (0fee7d4) 90.87% compared to head (7cca68e) 75.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #531       +/-   ##
===========================================
- Coverage   90.87%   75.89%   -14.98%     
===========================================
  Files           5        6        +1     
  Lines        2422     2900      +478     
===========================================
  Hits         2201     2201               
- Misses        221      699      +478     
Files Coverage Δ
src/Gurobi.jl 80.00% <ø> (ø)
src/gen110/libgrb_api.jl 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member

odow commented Nov 1, 2023

Can now be rebased onto master

@simonbowly
Copy link
Collaborator Author

I've re-generated the v11 headers using the new clang version. Tests are passing locally (though we can't test in CI until the v11 packages are available). Up to you if you want to merge it now or wait for the final release.

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you. We may as well make a release with it, and then it'll just work when people update. I know who to blame if there is an issue!

@odow odow merged commit db91456 into master Nov 2, 2023
2 of 4 checks passed
@odow odow deleted the gurobi-v11 branch November 2, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants