Fix pairwise drag dragging beyond form boundaries #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pairwise drag implementation would collect all nodes marker as a pair within the local node tree. This means that pairs found and other levels in the tree were considered for dragging and would allow eroneously dragging pairs outside of form boundaries. This fixes the issue by first filtering the matches nodes by those contained within the current form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pairwise drag implementation would collect all nodes marker as a pair within the local node tree.
This means that pairs found and other levels in the tree were considered for dragging and would allow eroneously dragging pairs outside of form boundaries.
This fixes the issue by first filtering the matches nodes by those contained within the current form.