Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new settings nodeIntegration #312 #314

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

new settings nodeIntegration #312 #314

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb6d4e1
new settings nodeIntegration
Nov 18, 2023
5d01b8e
new settings contextIsolation
Dec 3, 2023
46aac71
contextIsolation in settings
Dec 3, 2023
ad6d2a9
contextIsolation default to true
niconil Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/controller/mail-window-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ let mainMailServiceUrl;
let deeplinkUrls;
let safelinksUrls;
let mailServicesUrls;
let nodeIntegration;
let contextIsolation;
let showWindowFrame;
let $this;

Expand All @@ -34,6 +36,12 @@ class MailWindowController {
showWindowFrame =
settings.getSync("showWindowFrame") === undefined ||
settings.getSync("showWindowFrame") === true;
nodeIntegration =
settings.getSync("nodeIntegration") === undefined ||
settings.getSync("nodeIntegration") === true;
contextIsolation =
settings.getSync("contextIsolation") === undefined ||
settings.getSync("contextIsolation") === true;

mainMailServiceUrl =
settings.getSync("urlMainWindow") || "https://outlook.office.com/mail";
Expand Down Expand Up @@ -70,6 +78,8 @@ class MailWindowController {
deeplinkUrls: deeplinkUrls,
mailServicesUrls: mailServicesUrls,
safelinksUrls: safelinksUrls,
nodeIntegration: nodeIntegration,
contextIsolation: contextIsolation,
});
}
init() {
Expand All @@ -90,8 +100,8 @@ class MailWindowController {
webPreferences: {
spellcheck: true,
affinity: "main-window",
contextIsolation: false,
nodeIntegration: true,
contextIsolation: contextIsolation,
nodeIntegration: nodeIntegration,
},
});

Expand Down