Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement model constraint export #18758

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tlm
Copy link
Member

@tlm tlm commented Jan 30, 2025

This commit introduced a new model export operation for setting the model's constraints on export. The decision was made to seperate the export operations of the model domain into seperate entities so they can be easily tested.

This PR is a bit wishful at the moment as we don't have a reasonable test plan that can assert this work's besides the unit tests included. To merge this PR we need to:

Checklist

  • Code style: imports ordered, good names, simple structure, etc
  • Comments saying why design decisions were made
  • Go unit tests, with comments saying what you're testing
  • [ ] Integration tests, with comments saying what you're testing
  • [ ] doc.go added or updated in changed packages

QA steps

Test 1

Confirm the unit tests in this PR work

Test 2

This test will not work until the above mentioned items have landed.

  1. Bootstrap two controllers (one, two). Add a model to controller one called foo.
  2. On model foo set the model constraint for memory to 1024M
  3. Deploy the ubuntu charm to model foo and confirm everything is active in the model status.
  4. Migrate the model foo from controller one to controller two
  5. On controller two run juju model-constraints on the migrated model and confirm the memory constraint is set and applied.

Documentation changes

N/A

Links

Jira card: JUJU-7263

This commit introduced a new model export operation for setting the
model's constraints on export. The decision was made to seperate the
export operations of the model domain into seperate entities so they can
be easily tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants