[Fix] no-unknown-property: support onBeforeToggle, popoverTarget, popoverTargetAction attributes
#3865
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3865 +/- ##
==========================================
+ Coverage 94.34% 97.66% +3.32%
==========================================
Files 133 136 +3
Lines 9966 9978 +12
Branches 3703 3703
==========================================
+ Hits 9402 9745 +343
+ Misses 564 233 -331 ☔ View full report in Codecov by Sentry. |
acusti
force-pushed
the
popover-part-2
branch
from
73a1461 to
4a5678d
Compare
ljharb
requested changes
Dec 18, 2024
acusti
force-pushed
the
popover-part-2
branch
2 times, most recently
from
ebb2d15 to
76c57e0
Compare
ljharb
approved these changes
Jan 3, 2025
|
Tests are now failing, it seems. |
…`, `popoverTargetAction` attributes
|
@ljharb i added |
|
@ljharb Do you plan to merge/release this? |
|
@vitalyiegorov yes, that's why i approved it. |
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Jan 13, 2025
##### [v7.37.4](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7374---20250112) ##### Fixed - \[`no-unknown-property`]: support `onBeforeToggle`, `popoverTarget`, `popoverTargetAction` attributes ([#3865][] [@acusti](https://github.com/acusti)) - \[types] fix types of flat configs ([#3874][] [@ljharb](https://github.com/ljharb)) [7.37.4]: jsx-eslint/eslint-plugin-react@v7.37.3...v7.37.4 [#3874]: jsx-eslint/eslint-plugin-react#3874 [#3865]: jsx-eslint/eslint-plugin-react#3865
cswimr
pushed a commit
to cswimr/gauntlet-cswimr-plugins
that referenced
this pull request
Jan 20, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) | devDependencies | patch | [`7.37.3` -> `7.37.4`](https://renovatebot.com/diffs/npm/eslint-plugin-react/7.37.3/7.37.4) | --- ### Release Notes <details> <summary>jsx-eslint/eslint-plugin-react (eslint-plugin-react)</summary> ### [`v7.37.4`](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7374---20250112) [Compare Source](jsx-eslint/eslint-plugin-react@v7.37.3...v7.37.4) ##### Fixed - \[`no-unknown-property`]: support `onBeforeToggle`, `popoverTarget`, `popoverTargetAction` attributes ([#​3865][] [@​acusti](https://github.com/acusti)) - \[types] fix types of flat configs ([#​3874][] [@​ljharb](https://github.com/ljharb)) [7.37.4]: jsx-eslint/eslint-plugin-react@v7.37.3...v7.37.4 [#​3874]: jsx-eslint/eslint-plugin-react#3874 [#​3865]: jsx-eslint/eslint-plugin-react#3865 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDQuMyIsInVwZGF0ZWRJblZlciI6IjM5LjExOC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://www.coastalcommits.com/cswimr/gauntlet-cswimr-plugins/pulls/24 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3864