Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CacheClient.close() should adhere to contract #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

galderz
Copy link

@galderz galderz commented Dec 14, 2017

@cruftex
Copy link
Member

cruftex commented Dec 15, 2017

Comments relating to the PR from #136

Thanks for the PR. In the PR you now wrap all exceptions to IOExceptions.

There is no interface contract on Closeable, which says, that only IOExceptions are allowed.
Wrapping arbitrary RuntimeExceptions is not needed and contrary to the intention of the interface, which says: "@throws IOException if an I/O error occurs". A RuntimeException needs to be properly handled as well by any interface user.

If there is any exception on close, something is odd at another place. I cannot see how the PR relates to the problems you are experiencing.

@eolivelli
Copy link

This branch needs rebase
ERROR] Failed to execute goal on project cache-tests: Could not resolve dependencies for project javax.cache:cache-tests:jar:1.1.0-SNAPSHOT: Failure to find javax.cache:cache-api:jar:1.1.0-SNAPSHOT in https://repository-jsr107.forge.cloudbees.com/snapshot was cached in the local repository, resolution will not be reattempted until the update interval of cloudbees-snapshots has elapsed or updates are forced -> [Help 1]

Anyway I don't think this change is really needed in the TCK. I have read the discussion at #136 .
Is there still any strong need for this change ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants