Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow resolutions flag to build command #2556

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

JayaKrishnaNamburu
Copy link
Member

We need to allow resolutions too at times when building. Sharing more details about it here
https://github.com/jspm/jspm-vscode/compare/refactor-build-workflow

Copy link
Member

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, we should ensure CI is passing before landing, even if it's a skipped test with an issue posted.

@JayaKrishnaNamburu JayaKrishnaNamburu merged commit a3fd852 into main Dec 9, 2023
4 checks passed
@JayaKrishnaNamburu JayaKrishnaNamburu deleted the feat/add-resolutions-to-build-command branch December 9, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants