Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required declarations #76

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fix required declarations #76

merged 4 commits into from
Nov 29, 2023

Conversation

acao
Copy link
Collaborator

@acao acao commented Nov 29, 2023

This should fix #75

Tests need to include this validation error where they didn't include it before, and we need to fix this empty string pointer issue i think

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: 66bf5b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
codemirror-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for codemirror-json-schema ready!

Name Link
🔨 Latest commit 66bf5b5
🔍 Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/656751b81f1aad000868464e
😎 Deploy Preview https://deploy-preview-76--codemirror-json-schema.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@acao acao marked this pull request as draft November 29, 2023 10:21
@acao acao marked this pull request as ready for review November 29, 2023 14:56
@acao acao merged commit f5ab38a into main Nov 29, 2023
2 checks passed
@acao acao deleted the required-fix branch November 29, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"required" property not checked?
1 participant