Fix description markdown rendering in completion #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeMirror takes info as raw text if string, a function that returns dom is needed for HTML.
🦋 Changeset detectedLatest commit: af8869b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for codemirror-json-schema ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Ran into this as well, any updates on what it would take to get this merged? |
imolorhe
approved these changes
Sep 19, 2024
Merged
imolorhe
pushed a commit
that referenced
this pull request
Nov 16, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [#133](#133) [`4fd7cc6`](4fd7cc6) Thanks [@imolorhe](https://github.com/imolorhe)! - Get sub schema using parsed data for additional context - [#137](#137) [`29e2da5`](29e2da5) Thanks [@xdavidwu](https://github.com/xdavidwu)! - Fix description markdown rendering in completion - [#144](#144) [`ef7f336`](ef7f336) Thanks [@imolorhe](https://github.com/imolorhe)! - updated to use fine grained shiki bundle - [#139](#139) [`bfbe613`](bfbe613) Thanks [@NickTomlin](https://github.com/NickTomlin)! - Move non essential packages to devDependencies - [#140](#140) [`bceace2`](bceace2) Thanks [@NickTomlin](https://github.com/NickTomlin)! - Add CONTRIBUTING.md file Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, markdown-rendered HTML from description was rendered as plain text.
To test, use the demo with tsconfig.json schema and type a new property
tsto trigger completion forts-node, which description contains a link.