Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #105 - validate all strings #117

Merged
merged 1 commit into from
Jun 1, 2024
Merged

fix #105 - validate all strings #117

merged 1 commit into from
Jun 1, 2024

Conversation

acao
Copy link
Collaborator

@acao acao commented Jun 1, 2024

any string that is not empty, including whitespace strings, should validate?

Copy link

changeset-bot bot commented Jun 1, 2024

🦋 Changeset detected

Latest commit: b1d6a00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
codemirror-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao acao force-pushed the validate-strings branch from 0e16e2d to b1d6a00 Compare June 1, 2024 12:04
@acao acao merged commit edafa8f into main Jun 1, 2024
2 checks passed
@acao acao deleted the validate-strings branch June 1, 2024 12:33
@github-actions github-actions bot mentioned this pull request Jun 1, 2024
Copy link

@rookie-luochao rookie-luochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not seem to completely fix the validation problem

@imolorhe
Copy link
Collaborator

imolorhe commented Jun 2, 2024

@rookie-luochao what version are you using?

@rookie-luochao
Copy link

@rookie-luochao what version are you using?

0.7.6

acao pushed a commit that referenced this pull request Jun 2, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Patch Changes

- [#117](#117)
[`edafa8f`](edafa8f)
Thanks [@acao](https://github.com/acao)! - validate all strings with
length > 1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants