Handle generic validation error #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: da8a9a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for codemirror-json-schema ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was
linked to
issues
May 29, 2024
Closed
acao
reviewed
May 30, 2024
|
|
||
| export { | ||
| jsonSchemaLinter, | ||
| JSONValidation, |
There was a problem hiding this comment.
awesome, this takes care of another ticket i think
acao
pushed a commit
that referenced
this pull request
May 30, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [#103](#103) [`da7f368`](da7f368) Thanks [@imolorhe](https://github.com/imolorhe)! - Handle generic validation error Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't return validation errors when we don't have valid corresponding pointers. However we wouldn't always have valid pointers e.g. if the data isn't a valid JSON object (see #98)
Here I just
pushRootin those cases. We can consider adding the default root#pointer but the effect will be the same (i.e. by default all entries will at least match the root pointer and so will set the range to the root)