Improvements to completion logic (mainly for top level) #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8e00add The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for codemirror-json-schema ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
so excited to see this, I'm going to take a closer look tonight |
acao
force-pushed
the
imolorhe/improve-completion
branch
from
55e6301 to
8e00add
Compare
acao
pushed a commit
that referenced
this pull request
Jun 1, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [#102](#102) [`296617f`](296617f) Thanks [@imolorhe](https://github.com/imolorhe)! - Improvements to completion logic (mainly for top level) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to completion logic (mainly for top level). In true TDD fashion, I'm fairly confident with the changes given the tests are all passing.
Added additional tests for
I wanted to also work on the "include value completions for boolean" test case but there's a bit extra work (when completing the property value and the node used for the completion is different from the original node passed in to
getValueCompletions(), we also need to figure out the correctfromandtovalues for the completion context, so that applying the completion replaces the correct things, otherwise it will replace the original node which may not be what we want) to be done to get it working as expected, so decided to tackle part of it but leave it commented out for now.