feat: add improved prune() function #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdbaldry
reviewed
Apr 4, 2024
| '#': d.pkg( | ||
| name='reflect', | ||
| url='github.com/jsonnet-libs/xtd/reflect.libsonnet', | ||
| help='`reflect` implements helper functions for processing json data.', |
There was a problem hiding this comment.
nit:
Suggested change
| help='`reflect` implements helper functions for processing json data.', | |
| help='`reflect` implements helper functions for processing JSON data.', |
| else true; | ||
| local doRecursion(x) = | ||
| if recurse | ||
| then self.prune(x, only_null=only_null) |
There was a problem hiding this comment.
nit: I think it's more common to see that the recursive call uses the exact same arguments as the initial call because it explicitly demonstrates that the recursive call is gonna continue the same behavior.
Suggested change
| then self.prune(x, only_null=only_null) | |
| then self.prune(x, recurse, only_null) |
There was a problem hiding this comment.
For completeness, I think that all primitives need to exist in the test objects or at least zero-length arrays to demonstrate that the same std.prune behavior is preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It often comes up that
std.prune()is recursive, although the documentation states that it is, this still catches people off guard.The function introduced here provides options to disable recursion and only prune
nullvalues.