Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add justinrainbow/json-schema to tooling page #987

Merged

Conversation

heysujal
Copy link
Contributor

@heysujal heysujal commented Oct 1, 2024

What kind of change does this PR introduce?
This PR adds justinrainbow/json-schema to the tooling page as a validator.

As in the mentioned issue, the link for the logo was given. The image is not loading because the URL is not being picked up as it but it is being appended to some directory. Something like below

http://localhost:3000/img/tools/logos/https:/avatars.githubusercontent.com/u/170307068?s=200&v=4

I think this can be fixed by making changes to next.config.js
This is another issue on its own and I would like to work on it too.

Issue Number:

Screenshots/videos:
image

If relevant, did you update the documentation?
No

Summary

Does this PR introduce a breaking change?
No

@heysujal heysujal requested a review from a team as a code owner October 1, 2024 17:06
Copy link

github-actions bot commented Oct 1, 2024

Hey there 👋!

Are you an implementer of a new JSON Schema related tool, or an interested user submitting a tool you like?
If so, thanks for considering adding your tool to our collection -- and if not, sorry, I'm just a bot looking at which pages you're modifying!

Someone will review your pull request shortly.

In the interim, if you haven't already, there's a few things you might be interested in reviewing or confirming:

  1. Short description: Tell us a small bit about your tool! We love staying up to date on what's out there, and what your intentions are in writing it.
  2. Come Join Our Slack!: We have an #implementers channel for anyone interested in or building JSON Schema tooling!
    An invite can be found here or on our homepage!
  3. Common Interfaces: We maintain a page with some "commonly useful programming interfaces" that tooling may want to implement and present to your users.
    You can find that page here in our documentation.
    Have a read through and consider whether you implement or should implement any of what's there.
  4. Bowtie Harness: Bowtie is a tool which gives JSON Schema users access to a huge number of different implementations across many languages, and reports on the compliance of those implementations with the JSON Schema specifications.
    If it makes sense for your kind of tool, consider writing a harness which connects it to Bowtie. Instructions for doing so can be found in the tutorial in Bowtie's documentation.

If you have any questions, any feedback, or need help with the submission process, don't hesitate to reach out.
Thanks a bunch for your awesome contribution!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Oct 1, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview d6df32c

Copy link
Member

@DarhkVoyd DarhkVoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benjagm I am unsure about language versioning in environments, shouldn't this be in toolingListingNotes instead? Also, I believe logos should not be dynamic and be hosted as part of the website.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8551ee6) to head (d6df32c).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #987   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heysujal
Copy link
Contributor Author

heysujal commented Oct 2, 2024

I have added the image.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help!!

Can you please take a look to my comment?

data/tooling-data.yaml Outdated Show resolved Hide resolved
Copy link
Member

@DarhkVoyd DarhkVoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🚀

@DhairyaMajmudar DhairyaMajmudar added the Hacktoberfest-accepted Pull requests accepted for Hacktoberfest'24 label Oct 2, 2024
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot for this PR.

@benjagm benjagm merged commit 42a20db into json-schema-org:main Oct 4, 2024
10 checks passed
Copy link

github-actions bot commented Oct 4, 2024

Congratulations, @heysujal for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest-accepted Pull requests accepted for Hacktoberfest'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add justinrainbow/json-schema to tooling page
4 participants