Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix algolia search and removed duplicate dependencies #837

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

aialok
Copy link
Member

@aialok aialok commented Jul 30, 2024

What kind of change does this PR introduce?

  • Added Algolia search environment variables in the build step
  • Removed duplicate dependencies
  • Updated preview deployment workflow with correct environment variables
  • Fixed Husky CLI warning

image

Note:
In the preview deployment, the CF token environment variable was incorrect. It has now been fixed. However, this PR will fail because it is running on the event pull-request-target, which runs in the context of the default branch, not the forked branch. Once this PR is merged, the preview deployment will work correctly.

Issue Number:
N/A

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@aialok aialok requested a review from a team as a code owner July 30, 2024 16:05
@aialok aialok changed the title Fix algolia search and removed duplicated dependencies Fix algolia search and removed duplicate dependencies Jul 30, 2024
@benjagm
Copy link
Collaborator

benjagm commented Jul 30, 2024

Thanks for this PR!!

@benjagm benjagm merged commit e4305fe into json-schema-org:main Jul 30, 2024
5 of 7 checks passed
@aialok
Copy link
Member Author

aialok commented Jul 30, 2024

Thanks for this PR!!

Oh, I forget to mention you need to setup env secrets for Algolia in repository secrets.

@benjagm
Copy link
Collaborator

benjagm commented Jul 30, 2024

Oh, I forget to mention you need to setup env secrets for Algolia in repository secrets.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants