Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change documentation structure #802

Closed
wants to merge 0 commits into from
Closed

Change documentation structure #802

wants to merge 0 commits into from

Conversation

valeriahhdez
Copy link
Contributor

What kind of change does this PR introduce?

It changes the structure of the documentation website.

Issue Number:

Screenshots/videos: TODO

If relevant, did you update the documentation?

Summary

The changes introduced by this PR aim at improving the user experience with the documentation. We're organizing the information into content buckets that better align the reader's needs and learning journey.

Does this PR introduce a breaking change?
No, it doesn't

@valeriahhdez valeriahhdez requested a review from a team as a code owner July 18, 2024 16:39
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

@valeriahhdez valeriahhdez self-assigned this Jul 20, 2024
@valeriahhdez valeriahhdez added 📝 Documentation Indicates improvements or additions to documentation. GSoD Google Season of Docs labels Jul 20, 2024
@valeriahhdez
Copy link
Contributor Author

Hello @benjagm, @DhairyaMajmudar, and @kwennB

This PR is ready for review

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM from technical perspective, left few comments : )

pages/contributions/_index.md Outdated Show resolved Hide resolved
pages/contributions/contributions.md Outdated Show resolved Hide resolved
pages/introduction/_index.md Outdated Show resolved Hide resolved
components/Sidebar.tsx Outdated Show resolved Hide resolved
@DhairyaMajmudar
Copy link
Member

We have to also change the of resources and contributors tabs since currently they are same as concepts tab.
image

@valeriahhdez valeriahhdez marked this pull request as draft July 23, 2024 15:42
@valeriahhdez valeriahhdez marked this pull request as ready for review July 25, 2024 17:22
pages/contributions/contributions.md Outdated Show resolved Hide resolved
pages/contributions/contributions.md Outdated Show resolved Hide resolved
setOpen={setOpen}
/>
</div>
</div>
</div>

{/* Reference */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed no changes to the Reference section; I understood that this section needed a more intensive overhauling, i.e., by implementing Diataxis.

@benjagm
Copy link
Collaborator

benjagm commented Aug 13, 2024

Hi Valeria. I agree with the content buckets suggested in #790 but to implement it we don't necessarily need to move all the content to new folders. In my opinion, the first thing to do is to rename the sections in the sidebar and place the content in the right place. It is not mandatory to have the URLs to match the content bucket. Moving folders will require to create redirects for all the pages. Basically changing only the Sidebar component.

In addition, You added to this PR some contribution guides that are not part of the scope of issue #790 . That will require a separate issue. In addition, we already have a contributing file as @gregsdennis said. Why not adding the content there and use a symlink to show it as a page (As we do with sponsors and the code of conduct md files. I can help to implement this )

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments here:

#802 (comment)

@benjagm benjagm added the Status: In Progress This issue is being worked on, and has someone assigned. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Documentation Indicates improvements or additions to documentation. GSoD Google Season of Docs Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants