-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature : Added linkChecker workflow #604
Conversation
@benjagm , this is ready for review. Thank you : ) |
I don't think we should do this. |
Can you elaborate Ben? My only concern is how often we run this workflow and what to do with the results found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions and proposals.
Great work Alok!
Thanks for the review. I will be making the suggested changes : ) |
All suggested changes have been implemented:
Please manually run this workflow to check whether it is working fine or not. I have run it on my local dummy repo its working fine. Thank you : ) |
@benjagm , This is ready to review again. Please review. Thank you : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Great work!
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?