Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the footer space issue #494

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

Ali7040
Copy link
Contributor

@Ali7040 Ali7040 commented Mar 9, 2024

What kind of change does this PR introduce?
remove the mx-auto form sidebar because we have mx-4 and mx-auto both in same line. and fix the footer space issue.

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here in place of h-[100vh] you can use h-screen both will work same but the suggested one is a good practice to use.

Rest looks good to me : )

@Ali7040
Copy link
Contributor Author

Ali7040 commented Mar 9, 2024

Here in place of h-[100vh] you can use h-screen both will work same but the suggested one is a good practice to use.

Rest looks good to me : )

Thanks for your feedback. I will update it.

@Ali7040
Copy link
Contributor Author

Ali7040 commented Mar 9, 2024

Here in place of h-[100vh] you can use h-screen both will work the same but the suggested one is a good practice to use.

Rest looks good to me : )

Done :)

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@benjagm benjagm merged commit 551a978 into json-schema-org:main Mar 11, 2024
3 checks passed
@officeneerajsaini
Copy link
Contributor

Great @Ali7040

Akshaybagai52 pushed a commit to Akshaybagai52/website that referenced this pull request Mar 13, 2024
* fixed the footer space issue

* Change the class name to 'h-screen.'
Akshaybagai52 pushed a commit to Akshaybagai52/website that referenced this pull request Mar 13, 2024
* fixed the footer space issue

* Change the class name to 'h-screen.'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants