-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed the footer space issue #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here in place of h-[100vh]
you can use h-screen
both will work same but the suggested one is a good practice to use.
Rest looks good to me : )
Thanks for your feedback. I will update it. |
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Great @Ali7040 |
* fixed the footer space issue * Change the class name to 'h-screen.'
* fixed the footer space issue * Change the class name to 'h-screen.'
What kind of change does this PR introduce?
remove the mx-auto form sidebar because we have mx-4 and mx-auto both in same line. and fix the footer space issue.
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?