Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Github Workflow for Greeting contributor on their first PR merge #480

Merged
merged 5 commits into from
Mar 9, 2024
Merged

Added Github Workflow for Greeting contributor on their first PR merge #480

merged 5 commits into from
Mar 9, 2024

Conversation

Maykkkk
Copy link
Contributor

@Maykkkk Maykkkk commented Mar 8, 2024

benjagm
benjagm approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with workflow! The code is clean and does exactly what we expect it to do.

Looks great! Just left a small suggestion with the greeting message.

components/Layout.tsx Outdated Show resolved Hide resolved
.github/workflows/greet_on_first_merge.yml Outdated Show resolved Hide resolved
benjagm
benjagm approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@benjagm benjagm requested a review from gregsdennis March 8, 2024 12:48
@benjagm benjagm merged commit f245063 into json-schema-org:main Mar 9, 2024
3 checks passed
Akshaybagai52 pushed a commit to Akshaybagai52/website that referenced this pull request Mar 13, 2024
@Maykkkk @benjagm @Akshaybagai52
Added Github Workflow for Greeting contributor on their first PR merge (
3c6d74c 
json-schema-org#480)

* ci

* Update .github/workflows/greet_on_first_merge.yml

Co-authored-by: Benjamin Granados <[email protected]>

* Update Layout.tsx

---------

Co-authored-by: Benjamin Granados <[email protected]>
Akshaybagai52 pushed a commit to Akshaybagai52/website that referenced this pull request Mar 13, 2024
@Maykkkk @benjagm @Akshaybagai52
Added Github Workflow for Greeting contributor on their first PR merge (
6007744 
json-schema-org#480)

* ci

* Update .github/workflows/greet_on_first_merge.yml

Co-authored-by: Benjamin Granados <[email protected]>

* Update Layout.tsx

---------

Co-authored-by: Benjamin Granados <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjagm benjagm benjagm approved these changes

@gregsdennis gregsdennis Awaiting requested review from gregsdennis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature to greet users when they merge their first PR
2 participants
@Maykkkk @benjagm