Added dynamic icons to filters in tools page[Closes #1260] #1309
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1309 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
Sure Sir! I'll revert the changes. |
_includes/community
Outdated
There was a problem hiding this comment.
Can you please revert the changes in the community submodule?
There was a problem hiding this comment.
Yes, i have reverted The Changes.
components/Sidebar.tsx
Outdated
There was a problem hiding this comment.
How are these changes relevant to the linked issue for Tools Page?
| drafts: DialectIcon, | ||
| licenses: LicenseIcon, | ||
| }; | ||
|
|
There was a problem hiding this comment.
This object is redundant, it would better managed with filters object.
| { hidden: !isDropdownOpen }, | ||
| 'ml-0 mt-0 overflow-hidden transition-all duration-500 ease-in-out', | ||
| { | ||
| 'max-h-0 opacity-0 invisible': !isDropdownOpen, |
There was a problem hiding this comment.
Doesn't this make it more complicated?
There was a problem hiding this comment.
@bhat-shubham your CI checks are failing pls. fix them, also remove changes from submodule folders
|
@DhairyaMajmudar I have reverted the changes in the submodule as well as fixed the failing checks. |
What kind of change does this PR introduce?
This PR Closes Issue #1260 , adding dynamic and meaningful icons to each and every Filter on the Tools Page.
Issue Number:
Screenshots/videos:
Before-
After-
If relevant, did you update the documentation?
NA
Summary
Adds dynamic icons to the filters in Tools Page.
Does this PR introduce a breaking change?
NO
NA