Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update styles for dark mode in pro-help page #1299

Closed
wants to merge 1 commit into from

Conversation

Thund3rHawk
Copy link

What kind of change does this PR introduce?
Bug fix in the pro-help page

Issue Number:

Screenshots/videos:

Screen.Rec.JSON.Schema.mov

If relevant, did you update the documentation?
No

Summary
This pr resolves the issue #1289

Does this PR introduce a breaking change?
No

@Thund3rHawk Thund3rHawk requested a review from a team as a code owner January 12, 2025 21:06
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

@Thund3rHawk
Copy link
Author

@DhairyaMajmudar please check.

Copy link

github-actions bot commented Jan 12, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 25a82c5

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4fe7488) to head (25a82c5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1299   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DhairyaMajmudar
Copy link
Member

@Thund3rHawk pls. don't open PR without issues assignment and follow our community guidelines

@Thund3rHawk
Copy link
Author

HI @DhairyaMajmudar, Apologies for the oversight. I’ll ensure to follow the guidelines and wait for issue assignment before opening PRs. Thank you for your guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: More dark mode problems - pro-help
2 participants