Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md for better guidance for new contributors #1259

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Jan 7, 2025

Summary

We are making it more clear for new contributors the conditions to work on an Issue and submit a PR.

@benjagm benjagm requested a review from a team as a code owner January 7, 2025 09:18
Copy link

github-actions bot commented Jan 7, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview cbc0f51

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72ae168) to head (cbc0f51).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1259   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjagm benjagm changed the title Update CONTRIBUTING.md for better guide new contributors Update CONTRIBUTING.md for better guidance for new contributors Jan 7, 2025
@gregsdennis
Copy link
Member

gregsdennis commented Jan 7, 2025

I also noticed that the triage process doesn't say anything about discussing solutions to identify the actions that need to take place. The status goes from "triage" to "available". I think there should be an "in discussion" step that indicates, "Yes this is a valid issue, but we're uncertain how we want to address it. Opinions are welcome."

@Relequestual
Copy link
Member

I think these changes are helpful.
What do you think about also modifying the PR template to add some comments which directs people to the contribution guide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants