Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]-Add JSON Schema Editor tool #1210

Conversation

MadhavDhatrak
Copy link
Contributor

What kind of change does this PR introduce?
Feature: Added a new tool – JSON Schema Editor.

Issue Number:

Screenshots/videos:

screen-recording-2024-12-23-133439_ra6xoWH6.mp4

If relevant, did you update the documentation?
Documentation not required as this is a tool addition.

Summary
This PR introduces the JSON Schema Editor tool to the platform. It allows users to:

  • Easily build JSON schemas using an intuitive UI.
  • Convert JSON schemas into formats like SQL, GraphQL, and Protocol Buffers.
  • Generate sample data conforming to the defined JSON schema.
  • The addition enhances developer productivity by streamlining JSON schema creation and format conversions.

Does this PR introduce a breaking change?

No breaking changes introduced.

@MadhavDhatrak MadhavDhatrak requested a review from a team as a code owner December 26, 2024 11:08
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Dec 26, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 190abf9

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (11a66ee) to head (190abf9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1210   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @MadhavDhatrak, LGTM 👍🏻

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this only supports top level, and is very limited feature wise. I feel like we need to add something about this in the tooling listing notes.

@MadhavDhatrak
Copy link
Contributor Author

Hi @Relequestual ,

Thanks for the feedback! I've updated the PR to mention that the tool currently supports only top-level JSON schema creation.

I have also added the following tooling types to reflect the current functionality:
'editor'
'util-format-conversion'
'util-schema-to-schema'

Screenshot
Screenshot 2024-12-27 163516

Please review my changes and let me know if any further adjustments are needed.

@robclarabase
Copy link

As far as I can tell, this only supports top level, and is very limited feature wise. I feel like we need to add something about this in the tooling listing notes.

Hi @Relequestual - I worked on this project and would like to make the improvements you mentioned here in a subsequent iteration (not that it should be a blocker to this PR). Just so I understand correctly, does "only supports top level" refer to the lack of support for nested properties with an "object" type? Also what features/functionality would it need for it not be considered limited? Thanks!

@MadhavDhatrak MadhavDhatrak closed this by deleting the head repository Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Json schema editor tool submission
4 participants