-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]-Add JSON Schema Editor tool #1210
[Feat]-Add JSON Schema Editor tool #1210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @MadhavDhatrak, LGTM 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this only supports top level, and is very limited feature wise. I feel like we need to add something about this in the tooling listing notes.
Hi @Relequestual , Thanks for the feedback! I've updated the PR to mention that the tool currently supports only top-level JSON schema creation. I have also added the following tooling types to reflect the current functionality: Please review my changes and let me know if any further adjustments are needed. |
Hi @Relequestual - I worked on this project and would like to make the improvements you mentioned here in a subsequent iteration (not that it should be a blocker to this PR). Just so I understand correctly, does "only supports top level" refer to the lack of support for nested properties with an "object" type? Also what features/functionality would it need for it not be considered limited? Thanks! |
What kind of change does this PR introduce?
Feature: Added a new tool – JSON Schema Editor.
Issue Number:
Screenshots/videos:
screen-recording-2024-12-23-133439_ra6xoWH6.mp4
If relevant, did you update the documentation?
Documentation not required as this is a tool addition.
Summary
This PR introduces the JSON Schema Editor tool to the platform. It allows users to:
Does this PR introduce a breaking change?
No breaking changes introduced.