Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: next.js cache issue #1185

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

saurabhraghuvanshii
Copy link
Contributor

What kind of change does this PR introduce?

bug #1178 it clear Next.js cache in order to keep new css changes .

Issue Number:

Summary
close #1178 remove cache to show latest change to css
Does this PR introduce a breaking change?
no

@saurabhraghuvanshii saurabhraghuvanshii requested a review from a team as a code owner December 19, 2024 19:43
Copy link

github-actions bot commented Dec 19, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview d3f2e37

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (27398a9) to head (d3f2e37).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1185   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aialok
Copy link
Member

aialok commented Dec 19, 2024

image

hey, I think you misunderstood the issue. you just need to remove the above step.
Thanks for the PR

@saurabhraghuvanshii
Copy link
Contributor Author

@aialok sir this is present in two file build-preview.yml and production-deployment.yml , from which i should remove.

@aialok
Copy link
Member

aialok commented Dec 20, 2024

@aialok sir this is present in two file build-preview.yml and production-deployment.yml , from which i should remove.

Remove from the both so that it won't create problem in future.

@saurabhraghuvanshii
Copy link
Contributor Author

saurabhraghuvanshii commented Dec 20, 2024

@aialok check it sir, is this ok!

Copy link
Member

@aialok aialok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thanks @saurabhraghuvanshii

@saurabhraghuvanshii
Copy link
Contributor Author

@aialok thanks you sir for your guidance

@benjagm benjagm merged commit 28ddc52 into json-schema-org:main Dec 20, 2024
8 of 9 checks passed
@saurabhraghuvanshii saurabhraghuvanshii deleted the fix-cache branch December 20, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Remove Next.js build cache from preview.yml.
3 participants