Broken sidebar bug fix #1180
Broken sidebar bug fix #1180
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
pages/learn/index.page.tsx
Outdated
| @@ -39,7 +37,7 @@ export default function Welcome() { | |||
| link='https://tour.json-schema.org/' | |||
| /> | |||
| </div> | |||
| <DocsHelp markdownFile={markdownFile} /> | |||
| <DocsHelp /> | |||
There was a problem hiding this comment.
Oh, I think it is from one of the previous PR, where there was a redirect to a wrong page. I will correct this asap and will update the PR.
There was a problem hiding this comment.
Actually , this was part of some other PR , that solves redirecting issue , and by mistake it got reflected in this PR too.
I have rectified the changes. Kindly review the PR and suggest some changes if applicable.
|
Congratulations, @Utkarsh-123github for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
|
Thanks @benjagm , I'm looking forward to make more meaningful contributions. |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
No
Summary
This PR basically resolves the issue of broken content list in sidebar which is mentioned in the issue : #1172
Does this PR introduce a breaking change?
No