Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos, should always include JSON Schema, not only JSON #1171

Merged

Conversation

jeremyfiel
Copy link
Contributor

What kind of change does this PR introduce?

fix typos for the naming JSON Schema

Issue Number:

  • Closes #___
  • Related to #___
  • Others?

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@jeremyfiel jeremyfiel requested a review from a team as a code owner December 16, 2024 16:28
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you so much @jeremyfiel for the PR

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR Jeremy!! Much appreciated.

Can you please commit my suggestion? We have a process checking the formatting and this suggestion contains the required change.

pages/ambassadors/index.page.tsx Outdated Show resolved Hide resolved
@jeremyfiel jeremyfiel requested a review from benjagm December 18, 2024 20:55
Copy link

github-actions bot commented Dec 18, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 640f514

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR

@benjagm benjagm merged commit 6f36321 into json-schema-org:main Dec 18, 2024
6 of 7 checks passed
Copy link

Congratulations, @jeremyfiel for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

valeriahhdez pushed a commit to valeriahhdez/website that referenced this pull request Dec 19, 2024
…n-schema-org#1171)

* fix: typos, should always include `JSON Schema`, not only `JSON`

* Update pages/ambassadors/index.page.tsx

Co-authored-by: Benjamin Granados <[email protected]>

---------

Co-authored-by: Benjamin Granados <[email protected]>
valeriahhdez added a commit that referenced this pull request Dec 19, 2024
* add json schema conference blog images

* add JSON Schema conference article

* fix code quality

* Update pages/blog/posts/apidays-paris-2024-recap.md

Fix 2023 typo

Co-authored-by: Ben Hutton <[email protected]>

* Update apidays-paris-2024-recap.md

Fix apidays brand name and add figure tags

* Update apidays-paris-2024-recap.md

Correct all occurrences of the apidays brand name.

* fix: typos, should always include `JSON Schema`, not only `JSON` (#1171)

* fix: typos, should always include `JSON Schema`, not only `JSON`

* Update pages/ambassadors/index.page.tsx

Co-authored-by: Benjamin Granados <[email protected]>

---------

Co-authored-by: Benjamin Granados <[email protected]>

* Fix: Removing type failure and Restructring ambassadors page (#1173)

* fix:restructring ambassadors page

* Ambassador type fix

* reverting the changes related to imports

* fix: amabassadors import statement fixed

* route fix

* Update apidays-paris-2024-recap.md

Add space between figure one and paragraph; update date

---------

Co-authored-by: Ben Hutton <[email protected]>
Co-authored-by: Jeremy Fiel <[email protected]>
Co-authored-by: Benjamin Granados <[email protected]>
Co-authored-by: Dhairya Majmudar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants