-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typos, should always include JSON Schema
, not only JSON
#1171
fix: typos, should always include JSON Schema
, not only JSON
#1171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you so much @jeremyfiel for the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR Jeremy!! Much appreciated.
Can you please commit my suggestion? We have a process checking the formatting and this suggestion contains the required change.
Co-authored-by: Benjamin Granados <[email protected]>
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR
Congratulations, @jeremyfiel for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
…n-schema-org#1171) * fix: typos, should always include `JSON Schema`, not only `JSON` * Update pages/ambassadors/index.page.tsx Co-authored-by: Benjamin Granados <[email protected]> --------- Co-authored-by: Benjamin Granados <[email protected]>
* add json schema conference blog images * add JSON Schema conference article * fix code quality * Update pages/blog/posts/apidays-paris-2024-recap.md Fix 2023 typo Co-authored-by: Ben Hutton <[email protected]> * Update apidays-paris-2024-recap.md Fix apidays brand name and add figure tags * Update apidays-paris-2024-recap.md Correct all occurrences of the apidays brand name. * fix: typos, should always include `JSON Schema`, not only `JSON` (#1171) * fix: typos, should always include `JSON Schema`, not only `JSON` * Update pages/ambassadors/index.page.tsx Co-authored-by: Benjamin Granados <[email protected]> --------- Co-authored-by: Benjamin Granados <[email protected]> * Fix: Removing type failure and Restructring ambassadors page (#1173) * fix:restructring ambassadors page * Ambassador type fix * reverting the changes related to imports * fix: amabassadors import statement fixed * route fix * Update apidays-paris-2024-recap.md Add space between figure one and paragraph; update date --------- Co-authored-by: Ben Hutton <[email protected]> Co-authored-by: Jeremy Fiel <[email protected]> Co-authored-by: Benjamin Granados <[email protected]> Co-authored-by: Dhairya Majmudar <[email protected]>
What kind of change does this PR introduce?
fix typos for the naming
JSON Schema
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?