Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug:ambassadors Page #1162

Closed

Conversation

Pavankumar07s
Copy link
Contributor

What kind of change does this PR introduce?

Issue Number:

Screenshots/videos:
Screenshot from 2024-12-15 11-11-11
Screencast from 2024-12-15 11-11-17.webm

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@Pavankumar07s Pavankumar07s requested a review from a team as a code owner December 15, 2024 05:44
Copy link

github-actions bot commented Dec 15, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview f8d3393

@Pavankumar07s
Copy link
Contributor Author

Pavankumar07s commented Dec 15, 2024

@benjagm @DhairyaMajmudar could you please help me guiding in this 1 failed check.

@aialok
Copy link
Member

aialok commented Dec 15, 2024

@benjagm @DhairyaMajmudar could you please help me guiding in this 1 failed check.

image

This is actual issue.
There is some problem while importing the modules.

https://github.com/json-schema-org/website/actions/runs/12336270604/job/34428606371?pr=1162

@Pavankumar07s
Copy link
Contributor Author

@aialok I have noticed this error in the build information. I would like to understand why this error is occurring and learn about the reasons behind it.

@DhairyaMajmudar
Copy link
Member

@Pavankumar07s the errors are raising since index and ambassador are implicity typed as any, place proper type defination for both of these.

An another issue is with the import statement of ambassador.json file. Fix them all then you'll be good to go

@Pavankumar07s
Copy link
Contributor Author

@DhairyaMajmudar Alright 👍

@benjagm
Copy link
Collaborator

benjagm commented Dec 17, 2024

@Pavankumar07s Please make sure you run the command git submodule update to update the github submodules and make sure the community repo added as submodule is properly updated. Remember that the ambassadors data is maintained in another repo, not here.

The ambassadors.json we are using is a symlink in data/ambassadors.json pointing to the ambassadors.json of the github submodule pointing to community.

About github submodules:
https://git-scm.com/book/en/v2/Git-Tools-Submodules

About symlinks:
https://www.futurelearn.com/info/courses/linux-for-bioinformatics/0/steps/201767#:~:text=A%20symlink%20is%20a%20symbolic,directory%20in%20any%20file%20system.

@Pavankumar07s
Copy link
Contributor Author

Pavankumar07s commented Dec 17, 2024

Alright @benjagm i have tried all things in previous commits.

@DhairyaMajmudar
Copy link
Member

DhairyaMajmudar commented Dec 19, 2024

@Pavankumar07s the problem with workflow is fixed pls. merge your branch with the main and resolve conflicts

@Pavankumar07s
Copy link
Contributor Author

Alright @DhairyaMajmudar 👍

@Pavankumar07s Pavankumar07s deleted the BugAmbassadorsPavan branch December 19, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Padding of button in Become a JSON Schema Ambassador (Mobile view)
4 participants