Fix #1111 redirecting issue in Getting Started page #1149
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@Utkarsh-123github The CI issues have been resolved, and it's now working fine. I ran it again.
Thank you for your contribution!
|
Thanks @aialok for reviewing the issue. |
There was a problem hiding this comment.
@Utkarsh-123github I'm still getting 404 on clicking github redirect tab for faq, case studies and use-cases page. I would prefer to make a complete go through of all the pages and fix the broken links
|
@DhairyaMajmudar sure, I'll rectify all the broken links and will update the changes soon. Thanks for the review. |
|
Hey @DhairyaMajmudar , since we don't have related docs _index.md files for faq, case-studies and use-cases, so I have redirected to the codebase of the frontend part of respective pages when the user clicks on "Edit this page on Github" button. In future whenever we'll add the md files we'll just have to add the md file name and uncomment the code and everything will work smoothly and the user will be redirected to the respective docs. |
|
Closed in favour of #1117 |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
Screen.Recording.2024-12-03.231104.mp4
Summary
Basically, earlier on clicking the "Edit this page on Github" button , the user was redirected to a broken link https://github.com/json-schema-org/website/blob/main/pages/learn/_index.md . So, this PR resolves this issue by redirecting the user to https://github.com/json-schema-org/website/blob/main/pages/learn/index.page.tsx so that he/she may contribute effectively to that webpage.