Fix: Bad contrast in the blog's dark theme in info boxes #1143
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
occuring during preview
deployement
|
@DhairyaMajmudar The changes are not showing in the deployment i tried fixing it but the issue still persists even though it works on my dev server. |
|
@Relequestual can u please review my pr? |
|
If the changes are not showing up, it is surely related to the CSS Tailwind purge. We need to make sure we don't concatenate strings to create class names. https://v2.tailwindcss.com/docs/optimizing-for-production#writing-purgeable-html You will find more details in this PR: |
|
@benjagm idk why its still not working |
What kind of change does this PR introduce?
It fixes the Bad contrast in the Blog info boxes in Dark theme
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Fixed the info boxes in dark theme in blogs
Does this PR introduce a breaking change?
no