Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[obsolete-implementations]: Merge abandoned/obsolete tools data #1091

Merged
merged 12 commits into from
Dec 21, 2024

Conversation

DarhkVoyd
Copy link
Member

What kind of change does this PR introduce?
This PR aims to merge the existing obsolete implementations page and data with the new and updated tooling page.

Issue Number:
Related #928

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (73bcb7b) to head (657234d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1091   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 7, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 657234d

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi DV. This looks great. My only comment is the style of the obsolete label in dark theme. We need a darker text, otherwise the text is not visible. Maybe the same text color for all themes. What works for light I think will work for dark.

Screenshot 2024-12-13 at 09 21 45

@DarhkVoyd
Copy link
Member Author

Hey, I did add the correct styles for both light and dark theme but for some reason they aren't visible in the preview. Is there a way to disable and restart the preview workflow as fresh?

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good job DV!

@benjagm benjagm merged commit 8676fc2 into json-schema-org:main Dec 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants