Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the CI/CD pipeline to avoid broken links #103

Closed
1 task
benjagm opened this issue Oct 6, 2023 · 6 comments · Fixed by #604
Closed
1 task

Improve the CI/CD pipeline to avoid broken links #103

benjagm opened this issue Oct 6, 2023 · 6 comments · Fixed by #604
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Available No one has claimed responsibility for resolving this issue.

Comments

@benjagm
Copy link
Collaborator

benjagm commented Oct 6, 2023

After the site roll-out we found some broken links. In order to avoid this in the future we should improve the merge checks:

  • Add workflow to validate broken links.

GA Example to validate links:
https://github.com/openjs-foundation/cross-project-council/actions/runs/6412837418/workflow

@benjagm benjagm added the ✨ Enhancement Indicates that the issue suggests an improvement or new feature. label Nov 22, 2023
@benjagm benjagm moved this from Todo to Waiting for Contributions in Website Contributor Board Jan 19, 2024
@benjagm benjagm moved this from Waiting for Contributions to In Progress in Website Contributor Board Feb 12, 2024
@benjagm benjagm moved this from In Progress to Todo in Website Contributor Board Feb 13, 2024
@benjagm benjagm moved this from Todo to In Progress in Website Contributor Board Feb 13, 2024
@ayushnau
Copy link
Contributor

ayushnau commented Feb 13, 2024

@benjagm can I right the tests for it using puppeteer. which we can run with pipeline.

@benjagm benjagm added the Status: Available No one has claimed responsibility for resolving this issue. label Feb 20, 2024
@praveen-rikhari
Copy link
Contributor

Hey @ayushnau @benjagm is this available?? I can add this in the CI if it's still not worked on

@praveen-rikhari
Copy link
Contributor

I see we have some work already done in #297 to add this in the CI, and we need to first make sure if we have any broken links already on the website and fix them, right @benjagm??

@benjagm
Copy link
Collaborator Author

benjagm commented Feb 22, 2024

I see we have some work already done in #297

@Min2who is working on this.

we need to first make sure if we have any broken links already on the website and fix them

And we have this issue to fix the broken links found: #299

@benjagm benjagm moved this from In Progress to Waiting for Contributions in Website Contributor Board Feb 28, 2024
@benjagm benjagm moved this from Waiting for Contributions to In Progress in Website Contributor Board Mar 1, 2024
@benjagm benjagm moved this from In Progress to Waiting for Contributions in Website Contributor Board Mar 2, 2024
@benjagm benjagm moved this from Waiting for Contributions to Ready to Review in Website Contributor Board Mar 3, 2024
@benjagm benjagm moved this from Ready to Review to In Progress in Website Contributor Board Mar 9, 2024
@Relequestual
Copy link
Member

@benjagm Do we need to refine the Issue definition to make clear this is only for internal links?

@benjagm
Copy link
Collaborator Author

benjagm commented Apr 2, 2024

@benjagm Do we need to refine the Issue definition to make clear this is only for internal links?

That was not my idea when I created the issue. I think we should fix all broken links, internal and external.

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in Website Contributor Board Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Available No one has claimed responsibility for resolving this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants