-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests with ids in non-schemas to optional #707
Move tests with ids in non-schemas to optional #707
Conversation
5677992
to
b50e30b
Compare
I don't understand why this is being done -- are you expecting that implementations could either pass or fail these tests? But some of the things being tested here are mandatory -- such as that keywords that look like identifiers in non-schemas MUST NOT be treated as real identifiers. That's different from simply $ref-ing into non-schemas (which has undefined behaviour in the spec). |
@karenetheridge would you then expect only the tests which have pointer |
Yes, and I thought we'd already done that - because optional/refOfUnknownKeyword.json already exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree with @karenetheridge. These tests definitely are required. I've also left a few comments on them that might not be related to this PR specifically.
(I supposed I should look more closely at the content of the PR than just check to see if my implementation passes.)
Let's keep discussion in #700. @karenetheridge and @gregsdennis, I'd like to hear what you think about my last comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with these now. Thank you.
Resolves #700
This moves any tests that reference into locations not known to be a schema to the "optional" folder.