Fix parsing logic of function parameters with closing parentheses #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a function with parameter which have parentheses is wrongly parsed. As soon as a closing parentheses is encountered, the parsing logic assumes end state for the function parameter. For example, given `concat(sum(), 10)` then `sum(` is treated as first parameter. This is wrong parsing logic. A parameter should be treated completely parsed only when a `,` or, the last `)` is encountered ( that is groupParen == 0)
|
Test Scenario: Before this change, this would result in the below error. Here the internal |
…t to another function Add test for fixing parsing login when path has a function as argument to another function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a function with parameter which have parentheses is wrongly parsed. As soon as a closing parentheses is encountered, the parsing logic assumes end state for the function parameter. For example, given
concat(sum(), 10)thensum(is treated as first parameter. This is wrong parsing logic.A parameter should be treated completely parsed only when a
,or, the last)is encountered ( that is groupParen == 0)