Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use snapshot of rosdep list on melodic #457

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

pazeshun
Copy link
Collaborator

After ros/rosdistro#39174 was merged, rosdep key python-omniorb cannot be resolved on melodic.
This makes an error on rosdep install without -r option:
https://app.travis-ci.com/github/start-jsk/jsk_apc/jobs/615633458

This PR fixes that error by using snapshot of rosdep list on melodic as well as kinetic and under.
Result:
https://app.travis-ci.com/github/start-jsk/jsk_apc/jobs/616059276
Of course, adding -r option to rosdep install is another solution, but I think it is good time to use snapshot because melodic is EOL and no longer maintained on rosdistro:
ros/rosdistro#39223 (comment)

Minor fixes

  • Include snapshot of rosdep list in this repository to increase portability of this repository
    • Otherwise we have to create a github gist every time when we have to create a new snapshot

@pazeshun
Copy link
Collaborator Author

pazeshun commented Jan 11, 2024

@k-okada CI passed, could you review this?
One concern is that this PR may break backward compatibility and we may need to add changes to CI yamls of each repository like the following:
8d36659
I searched code under jsk-ros-pkg and start-jsk:
https://github.com/search?q=org%3Ajsk-ros-pkg+%22mkdir+.travis%22&type=code
https://github.com/search?q=org%3Astart-jsk+%22mkdir+.travis%22&type=code
and I currently do not think we have such case.
But please tell me if I am wrong.

@k-okada k-okada merged commit b972f7e into jsk-ros-pkg:master Jan 15, 2024
40 checks passed
@pazeshun pazeshun deleted the lock-melodic-rosdep branch January 15, 2024 07:49
@pazeshun
Copy link
Collaborator Author

@k-okada Thank you! Could release this as 0.5.27?

@k-okada
Copy link
Member

k-okada commented Jan 15, 2024

Sorry for the delay. I tried to release it right after the merge, but forgot all about it.

@pazeshun
Copy link
Collaborator Author

Thank you for releasing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants