Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_perception] Enable catkin_virtualenv to fix pytesseract version #2729

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iory
Copy link
Member

@iory iory commented Sep 20, 2022

What is this?

It is not possible at this stage to fix the version of the python library in package.xml.
This PR uses catkin virtualenv to fix pytesseract's version. It drops python2 support.

@iory
Copy link
Member Author

iory commented Sep 20, 2022

To support catkin_virtualenv on indigo, we need to run

sed -i 's/upgrade_pip=True/upgrade_pip=False/' /opt/ros/indigo/share/catkin_virtualenv/cmake/build_venv.py

to prevent upgrading to the latest pip, which is not Python2 compatible.
This PR needs jsk-ros-pkg/jsk_travis#452 to pass a test on indigo.

@k-okada
Copy link
Member

k-okada commented Jan 25, 2023

@iory please resovle conflict, and why jsk-ros-pkg/jsk_travis#452 requried to pass tests? I understand jsk-ros-pkg/jsk_travis#452 is usefull, but jsk-ros-pkg/jsk_3rdparty#342 passed without this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants