Fixed a node v12 compatibility issue

jsdoc2md · Aug 31, 2024 · db480f1 · db480f1
1 parent 0e3c820
commit db480f1
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 14 deletions.
diff --git a/dist/index.cjs b/dist/index.cjs
@@ -43,12 +43,12 @@ const { __dirname: __dirname$1 } = currentModulePaths((typeof document === 'unde
 
 class JsdocCommand {
   constructor (options = {}, cache) {
+    options.files = arrayify(options.files);
+    options.source = arrayify(options.source);
     assert.ok(
-      options.files?.length || options.source || options.configure,
+      options.files.length || options.source.length || options.configure,
       'Must set at least one of .files, .source or .configure'
     );
-    options.files = arrayify(options.files);
-    options.source = arrayify(options.source);
 
     this.cache = cache;
     this.tempFiles = [];
@@ -308,7 +308,7 @@ class JsdocOptions {
     this.readme = options.readme;
 
     /* Warning to avoid a common mistake where dmd templates are passed in.. a jsdoc template must be a filename. */
-    if (options.template !== undefined && options.template?.split(/\r?\n/)?.length !== 1) {
+    if (typeof options.template === 'string' && options.template.split(/\r?\n/).length !== 1) {
       console.warn('Suspicious `options.template` value - the jsdoc `template` option must be a file path.');
       console.warn(options.template);
     }

diff --git a/index.js b/index.js
@@ -140,7 +140,7 @@ class JsdocOptions {
     this.readme = options.readme
 
     /* Warning to avoid a common mistake where dmd templates are passed in.. a jsdoc template must be a filename. */
-    if (options.template !== undefined && options.template?.split(/\r?\n/)?.length !== 1) {
+    if (typeof options.template === 'string' && options.template.split(/\r?\n/).length !== 1) {
       console.warn('Suspicious `options.template` value - the jsdoc `template` option must be a file path.')
       console.warn(options.template)
     }

diff --git a/lib/jsdoc-command.js b/lib/jsdoc-command.js
@@ -10,12 +10,12 @@ const { __dirname } = currentModulePaths(import.meta.url)
 
 class JsdocCommand {
   constructor (options = {}, cache) {
+    options.files = arrayify(options.files)
+    options.source = arrayify(options.source)
     assert.ok(
-      options.files?.length || options.source || options.configure,
+      options.files.length || options.source.length || options.configure,
       'Must set at least one of .files, .source or .configure'
     )
-    options.files = arrayify(options.files)
-    options.source = arrayify(options.source)
 
     this.cache = cache
     this.tempFiles = []

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/lib/fixture.js b/test/lib/fixture.js
@@ -26,7 +26,8 @@ class Fixture {
   static createTmpFolder (folder) {
     try {
       fs.statSync(folder)
-      fs.rmSync(folder, { recursive: true })
+      /* rmdirSync is node v12 friendly */
+      fs.rmdirSync(folder, { recursive: true })
       fs.mkdirSync(folder)
     } catch (err) {
       fs.mkdirSync(folder)