Fit, flow & reposition #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
height and maxHeight option can pass a callback function or string 'auto', for recalculating height/maxHeight of modal-body everytime window's size changed.
Modal with '.modal-reposition' class will listen to any input 'change' event to check modal-size changed and fire 'resize.modal'.
The "change" event may be triggered by input, select and textarea element within modal. Otherwise required writing a custom script to trigger when ajax loading complete or trigger every specific interval .
…bootstrap-modal/master
| @@ -104,6 +104,11 @@ | |||
| var prop = this.options.height ? 'height' : 'max-height', | |||
| value = this.options.height || this.options.maxHeight; | |||
|
|
|||
| if (!value && this.$element.hasClass('modal-fit')){ | |||
| value = function(){return $(window).height() - 165} | |||
There was a problem hiding this comment.
I think the value 165 shouldn't be hardcoded if we're going to include the "contrain modal to window size" example from the docs. This wouldn't work quite right for all cases (i.e no header or footer, any font/padding style changes etc..)
Would be nice if we could compute the actual value. Something like windowHeight - headerHeight - footerHeight - marginBetweenModalAndWindow.
|
For some reason I can't auto merge this PR but can #72 be closed? Seems like it contains both functionalities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just add the "Fit, Flow & Reposition" demo using my wip branch at last section of page.
http://jojosati.github.com/bootstrap-modal/demo.html