When labeling Metal objects, add a unique identifier.

It shows up in the GPU capture and in case of a GPU crash in the crash report.
js6i · Aug 9, 2024 · 8068084 · 8068084
1 parent 07d7bfb
commit 8068084
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/MoltenVK/MoltenVK/GPUObjects/MVKVulkanAPIObject.h b/MoltenVK/MoltenVK/GPUObjects/MVKVulkanAPIObject.h
@@ -126,7 +126,8 @@ class MVKDispatchableVulkanAPIObject : public MVKVulkanAPIObject {
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wobjc-method-access"
 /** Generically avoids setting a label to nil, which many objects don't like. */
-static inline void setLabelIfNotNil(id object, NSString* label) { if (label) { [object setLabel: label]; } }
+extern std::atomic<uint64_t> nextMetalObjectIdentifier;
+static inline void setLabelIfNotNil(id object, NSString* label) { if (label) { [object setLabel: [label stringByAppendingFormat:@" (%llu)", nextMetalObjectIdentifier++]]; } }
 #pragma clang diagnostic pop
 
 
diff --git a/MoltenVK/MoltenVK/GPUObjects/MVKVulkanAPIObject.mm b/MoltenVK/MoltenVK/GPUObjects/MVKVulkanAPIObject.mm
@@ -24,6 +24,8 @@
 #pragma mark -
 #pragma mark MVKVulkanAPIObject
 
+std::atomic<uint64_t> nextMetalObjectIdentifier;
+
 VkResult MVKVulkanAPIObject::setDebugName(const char* pObjectName) {
 	if (pObjectName) {
 		[_debugName release];