Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better-upload.js.org #9338

Merged
merged 2 commits into from
Oct 20, 2024
Merged

better-upload.js.org #9338

merged 2 commits into from
Oct 20, 2024

Conversation

Nic13Gamer
Copy link
Contributor

@Nic13Gamer Nic13Gamer commented Oct 19, 2024

Better Upload is library for React that simplifies file uploads.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Do you have a link to where we can preview the content prior to merging this?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Oct 20, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the CI error notes, your entry needs to be in alphabetical order and as you're using Vercel you'll want the Cloudflare proxy disabled with the // noCF comment at the end of the line.

@Nic13Gamer
Copy link
Contributor Author

Fixed. Thank you!

You can preview it here.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://better-upload.vercel.app/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed invalid awaiting response This PR is waiting for a response from the requester labels Oct 20, 2024
@indus
Copy link
Member

indus commented Oct 20, 2024

Welcome http://better-upload.js.org

@indus indus merged commit 7e65a84 into js-org:master Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants