Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aoimysql.js.org #9330

Merged
merged 4 commits into from
Oct 15, 2024
Merged

aoimysql.js.org #9330

merged 4 commits into from
Oct 15, 2024

Conversation

tyowk
Copy link
Contributor

@tyowk tyowk commented Oct 14, 2024

@tyowk tyowk changed the title Update cnames_active.js aoimysql.js.org Oct 14, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Do you have a link to where we can preview your content prior to merging?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Oct 14, 2024
@tyowk
Copy link
Contributor Author

tyowk commented Oct 14, 2024

👋 Do you have a link to where we can preview your content prior to merging?

https://aoimysql.vercel.app

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://aoimysql.vercel.app/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed awaiting response This PR is waiting for a response from the requester labels Oct 14, 2024
@tyowk
Copy link
Contributor Author

tyowk commented Oct 15, 2024

eee... @MattIPv4

the cname value is "cname.vercel-dns.com." and not just ".com" 🙂

1728956082551

@MattIPv4
Copy link
Member

They are functionally the same, the CI is going to want it without the trailing .

@tyowk
Copy link
Contributor Author

tyowk commented Oct 15, 2024

They are functionally the same, the CI is going to want it without the trailing .

oh ok

@indus
Copy link
Member

indus commented Oct 15, 2024

Welcome http://aoimysql.js.org

@indus indus merged commit b9193db into js-org:master Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants