Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

olova.js.org #9325

Closed
wants to merge 2 commits into from
Closed

olova.js.org #9325

wants to merge 2 commits into from

Conversation

seraprogrammer
Copy link
Contributor

@seraprogrammer seraprogrammer commented Oct 11, 2024

@MattIPv4 MattIPv4 changed the title Update cnames_active.js olova.js.org Oct 11, 2024
@MattIPv4
Copy link
Member

👋 FYI you don't need to keep opening new PRs, you can edit your existing PR.

@MattIPv4 MattIPv4 mentioned this pull request Oct 11, 2024
2 tasks
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Your requested js.org subdomain must be inserted in alphabetical order in the cnames_active.js file before we can process your request. Please fix this. 🔤

Copy link
Contributor Author

@seraprogrammer seraprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check ,
cnames_active !

@indus
Copy link
Member

indus commented Oct 11, 2024

@seraprogrammer I've check and it is still not in alphabetical order. Also there is a . at the end of your target and you are missing the // noCF comment:

Have a look at the errors here: https://github.com/js-org/js.org/actions/runs/11285733214/job/31389159166?pr=9325

@indus
Copy link
Member

indus commented Oct 11, 2024

#9326

@indus indus closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants