Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcium.js.org #8465

Merged
merged 3 commits into from
Aug 28, 2023
Merged

calcium.js.org #8465

merged 3 commits into from
Aug 28, 2023

Conversation

NriotHrreion
Copy link
Contributor

@NriotHrreion NriotHrreion commented Aug 27, 2023 •
edited
Loading

This app is written in React & Typescript by me.

You can go to https://calc.nin.red or https://courageous-bublanina-6857c1.netlify.app to preview this app.

@MattIPv4
Copy link
Member

@indus I'm not sure this is related to the JavaScript ecosystem/community really, it is a calculator that happens to be written with JS? Thoughts?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Aug 27, 2023
@NriotHrreion
Copy link
Contributor Author

NriotHrreion commented Aug 27, 2023 •
edited
Loading

@indus I'm not sure this is related to the JavaScript ecosystem/community really, it is a calculator that happens to be written with JS? Thoughts?

Well, I often have discussion with my friends about the Javascript behind this app. I also like thinking about how to make this app better by Javascript and often try some Javascript techniques I learnt from other places on this app. So, at least for me, I think this is related to the Javascript community.

@indus
Copy link
Member

indus commented Aug 27, 2023 •
edited
Loading

I tend to accept it but would suggest to go for calcium.js.org.

-> https://github.com/nocpiun/calcium#why-its-name-is-calcium

@indus indus added add This PR/issue is regarding adding a new subdomain name mismatch This PR has a subdomain request that does not align with the requester or target external page This PR has a target of a site that isn't GitHub Pages and removed awaiting response This PR is waiting for a response from the requester labels Aug 27, 2023
@NriotHrreion
Copy link
Contributor Author

I tend to accept it but would suggest to go for calcium.js.org.

-> https://github.com/nocpiun/calcium#why-its-name-is-calcium

It's also fine, but I prefer calc.js.org because it's shorter and easier to remember.

@indus
Copy link
Member

indus commented Aug 28, 2023

calc is super generic and it really says "Calcium" all over your page. I don't see it as an exception as described here: https://github.com/js-org/js.org/wiki/Subdomain-Determination#exceptions

@NriotHrreion
Copy link
Contributor Author

calc is super generic and it really says "Calcium" all over your page. I don't see it as an exception as described here: https://github.com/js-org/js.org/wiki/Subdomain-Determination#exceptions

Ok, I'll change it to calcium.js.org

@NriotHrreion NriotHrreion changed the title calc.js.org calcium.js.org Aug 28, 2023
@indus indus added 404 The page requested returns a 404 response and removed name mismatch This PR has a subdomain request that does not align with the requester or target labels Aug 28, 2023
@indus
Copy link
Member

indus commented Aug 28, 2023

I've already added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain.
I'll merge after we have "contact". Please keep this PR open.

@NriotHrreion
Copy link
Contributor Author

I've configured my netlify domain settings and my app is available on calcium.js.org now.

@indus indus removed the 404 The page requested returns a 404 response label Aug 28, 2023
@indus
Copy link
Member

indus commented Aug 28, 2023

Welcome https://calcium.js.org

@indus indus merged commit 782cd86 into js-org:master Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NriotHrreion @MattIPv4 @indus