Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typedi.js.org #8420

Merged
merged 1 commit into from
Aug 3, 2023
Merged

typedi.js.org #8420

merged 1 commit into from
Aug 3, 2023

Conversation

freshgum-bubbles
Copy link
Contributor

@freshgum-bubbles freshgum-bubbles commented Aug 2, 2023

Source: https://github.com/freshgum-bubbles/typedi/tree/gh-pages

@freshgum-bubbles freshgum-bubbles changed the title Add typedi.github.io Add typedi.js.org -> freshgum-bubbles.github.io/typedi/ Aug 2, 2023
@freshgum-bubbles
Copy link
Contributor Author

Re: "reasonable content"...

image

The site hosts extensive documentation for a TypeScript library :-)
Definitely reasonable; I've spent a good few weeks on this site.

@freshgum-bubbles freshgum-bubbles marked this pull request as draft August 2, 2023 17:02
@freshgum-bubbles
Copy link
Contributor Author

Moved this to draft to clarify something + ensure it isn't merged before I'm 100% sure the name is right for the project.

Would https://freshgum.js.org/typedi/ be acceptable?

Your README states any blogs, etc. wouldn't be welcome on the js.org subdomain, so not 100% sure what I would use that for; I'm just thinking this would reduce disambiguation between this project and the (abandoned) upstream project which it was originally based on.

The package name is @freshgum/typedi, which seems more appropriate and much less ominous. I'm wondering if it'd be better to have the domain name sort of matching that, like the one proposed above, so it all makes a bit more sense.

@MattIPv4
Copy link
Member

MattIPv4 commented Aug 2, 2023

Would https://freshgum.js.org/typedi/ be acceptable?

I don't really think so, as you'd be requesting the subdomain freshgum.js.org for you user, which would not fall within our acceptable content guidelines.

@MattIPv4 MattIPv4 changed the title Add typedi.js.org -> freshgum-bubbles.github.io/typedi/ typedi.js.org Aug 2, 2023
@freshgum-bubbles
Copy link
Contributor Author

Ok, TypeDI.js.org it is then.

@freshgum-bubbles freshgum-bubbles marked this pull request as ready for review August 3, 2023 12:09
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Aug 3, 2023
@indus
Copy link
Member

indus commented Aug 3, 2023

Welcome https://typedi.js.org
(FYI: there is a problem with the baseURL)

@indus indus merged commit 7bb583d into js-org:master Aug 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants