-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semantic-api.js.org #8416
semantic-api.js.org #8416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there!
❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝
I thought putting it in CNAME file was enough, sorry. |
Ah yeah, the CNAME file only works from branch-based GitHub Pages deployments. If you're using the new Action to push directly to Pages itself, not a branch, you just need the repository setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Commit valid, CNAME present, site appears to have content *
* based off https://github.com/semantic-api/docs
I've already added your requested subdomain to JS.ORGs zonefile. But as you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment) |
@ringeringeraja The problem here looks similar to this: #8294 (comment) |
It was already unchecked. I did multiple steps, including removing and adding the domain again, deleting the CNAME file, etc. It isn't clear what exactly was the problem. Anyway, the subdomain now works. Thanks! |
Good to know. Please keep the PR open. I will merge it tomorrow.Am 01.08.2023 20:18 schrieb João Santos ***@***.***>:
@ringeringeraja The problem here looks similar to this: #8294 (comment) Please make sure that the "Enforce Https" setting is unchecked.
It was already unchecked. I did multiple steps, including removing and adding the domain again, deleting the CNAME file, etc. It isn't clear what exactly was the problem. Anyway, the subdomain now works. Thanks!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
There's still content missing but buttons on the homepage lead to contentful pages. There's also the API reference on top right corner of the page. Stuff left will be added soon.
https://github.com/ringeringeraja/semantic-api
The repository will be moved to the link on the page as soon as it gets released.