Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-api.js.org #8416

Merged
merged 2 commits into from
Aug 2, 2023
Merged

semantic-api.js.org #8416

merged 2 commits into from
Aug 2, 2023

Conversation

minenwerfer
Copy link
Contributor

There's still content missing but buttons on the homepage lead to contentful pages. There's also the API reference on top right corner of the page. Stuff left will be added soon.

https://github.com/ringeringeraja/semantic-api
The repository will be moved to the link on the page as soon as it gets released.

@MattIPv4 MattIPv4 changed the title I've updated my website to match this repo criteria semantic-api.js.org Jul 31, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Jul 31, 2023
@minenwerfer
Copy link
Contributor Author

Hi there!

x Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. memo

I thought putting it in CNAME file was enough, sorry.
It's done now.

@MattIPv4
Copy link
Member

Ah yeah, the CNAME file only works from branch-based GitHub Pages deployments. If you're using the new Action to push directly to Pages itself, not a branch, you just need the repository setting.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/semantic-api/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Jul 31, 2023
@indus indus added the error The page requested returns an error label Aug 1, 2023
@indus
Copy link
Member

indus commented Aug 1, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But as you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment)

@indus
Copy link
Member

indus commented Aug 1, 2023

@ringeringeraja The problem here looks similar to this: #8294 (comment)
Please make sure that the "Enforce Https" setting is unchecked.

@minenwerfer
Copy link
Contributor Author

@ringeringeraja The problem here looks similar to this: #8294 (comment) Please make sure that the "Enforce Https" setting is unchecked.

It was already unchecked. I did multiple steps, including removing and adding the domain again, deleting the CNAME file, etc. It isn't clear what exactly was the problem. Anyway, the subdomain now works. Thanks!

@indus
Copy link
Member

indus commented Aug 1, 2023 via email

@indus indus removed the error The page requested returns an error label Aug 2, 2023
@indus indus merged commit 2af2930 into js-org:master Aug 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants