Filterable: Add a data-no-filter attribute #8185
Conversation
Add a data-no-filter attribute for an item such that it will always show in both normal and reveal mode when its data-no-filter="true" Closes jquery-archivegh-8184
|
@carsonip can you please sign the CLA? |
|
@arschmitz I have signed it twice with different names but with the same correct email address. Please check. |
|
@carsonip thank you. We have decided to add this feature though the implementation might be a bit different. Ill review this soon and give you feedback. |
|
The CLA signature is fine now. |
|
@carsonip sorry about the delay in this finally ready to add this feature. Im wondering if it might be better / more flexible to add an option |
|
I agree with @arschmitz that an option would be more convenient in this case. |
|
@arschmitz Sorry for the late reply. I would love to improve the request. Could you elaborate more about the |
|
@carsonip ignore option will have a value of string which would a valid html selector for the items which should not be filtered. |
Replaced data-no-filter with data-ignore according to the comments of jQuery members. Looks more flexible now.
|
Sorry for the wait. I have updated the PR according to the comments. Not sure if there will be a significant performance hit since we will create a jQuery object from each item such that we can use the |
|
What is the status of this PR? If it should be merged, who can sign the Contributor License Agreement? |
Add a data-no-filter attribute for an item such that it will always show in both normal and reveal mode when its data-no-filter="true"
Closes gh-8184