Skip to content
This repository has been archived by the owner on May 26, 2020. It is now read-only.

Add setting for extending the orig_iat for token-refresh and also causes a new token value to be generated when refreshing a token #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaronlelevier
Copy link

I'm submitting this PR, so that refresh token values are different every time when refreshing a token.

I had originally submitted issue #356

I did some testing, and in fact the original token value is returned when doing a token refresh, as long as the the "orig_iat" is less than the expiration delta, where the default is 7 days.

There may be a use case, and I myself would like to have this feature, where the token value is different every time a token is refreshed.

I added tests and documentation. If this PR is conceptually acceptable, but maybe some changes are needed and so on, please let me know, and I'd be happy to make some changes. I'd just like to see the overall feature land, so we can use it.

Thank you

@aaronlelevier aaronlelevier force-pushed the extend-orig-iat-setting branch from dd10d63 to 6d00aaf Compare September 8, 2017 19:28
@blueyed
Copy link
Contributor

blueyed commented Sep 15, 2017

Please rebase this since now the tests should be fixed again.

…ses a new token value to be generated when refreshing a token
@aaronlelevier aaronlelevier force-pushed the extend-orig-iat-setting branch from 6d00aaf to 5b9d4e6 Compare September 15, 2017 19:46
@aaronlelevier
Copy link
Author

@blueyed thank you for the bump. The tests passed. What do you all think about my PR?

I hope that I addressed the feature correctly, and it's a feature that you all want. Another person on my team had noticed that it's the same token value if the orig_iat is the same, so I wanted to make this PR.

Thanks

@blueyed
Copy link
Contributor

blueyed commented Sep 15, 2017

I do not like new settings personally..

Is it related to #348 even after all?

@aaronlelevier
Copy link
Author

aaronlelevier commented Sep 15, 2017

It relates to #348 but it's different.

So maybe the issue is that orig_iat is in days, and so the same token value will persist for a minimum of 1 day, depending on how you set the setting.

What about allowing for a different time interval for orig_iat other than days?

@crodriguez1a
Copy link

crodriguez1a commented Oct 5, 2017

@blueyed @aronysidoro I think this PR covers two distinct issues that both deserve a second look. One was sort of covered here (not sure if documentation will be updated?). The other part I'm still not clear on. It seems that this PR would address it. Should the expectation be that content of the token upon refresh would not be re-computed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants