fix: highlight should also register event listeners

josias-r · Oct 28, 2022 · aa4d027 · aa4d027
1 parent 4b8e68f
commit aa4d027
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/lib/boarding.ts b/src/lib/boarding.ts
@@ -99,8 +99,6 @@ class Boarding {
    * @param selector Query selector, htmlelement or a step definition
    */
   public highlight(selector: BoardingStepDefinition | string | HTMLElement) {
-    this.isActivated = true;
-
     // convert argument to step definition
     const stepDefinition: BoardingStepDefinition =
       typeof selector === "object" && "element" in selector
@@ -111,7 +109,10 @@ class Boarding {
     if (!element) {
       return;
     }
+    // attach eventListeners BEFORE setting highlighting element
+    this.attachEventListeners();
 
+    this.isActivated = true;
     this.overlay.highlight(element);
   }